Move PhD auxiliary-file generation out to php/phd#318
Open
lacatoire wants to merge 2 commits into
Open
Conversation
configure.php now only assembles and validates the XML. The generation of version.xml, sources.xml and fileModHistory.php is removed (phd_acronym, php_history, phd_sources, phd_version) and delegated to php/phd via a doc-base/temp/phd-conf.json handoff. Also fixes the --history-file option, which set SOURCES_FILE instead of HISTORY_FILE. Depends on php/phd (adds genphdfiles.php). The build pipeline must call 'php phd/genphdfiles.php doc-base/temp/phd-conf.json' before this lands.
Member
|
Wow! That is exactly what I was thinking of. Paint me very impressed. The moved files are mentioned in |
version.xml, sources.xml and fileModHistory.php are now generated by PhD (genphdfiles.php), not by configure.php, so doc-base no longer produces them.
Member
|
I think the doc-base side is ok. You can merge here at your earliest convenience, and yet, let this open a few days, for comments and/or reviews. I will do a heads up no Discord, to be sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following php/phd#253 (comment). configure.php now only assembles and validates the XML.
Removes the generation of version.xml, sources.xml and fileModHistory.php (phd_acronym, php_history, phd_sources, phd_version), writing a doc-base/temp/phd-conf.json handoff instead. Also fixes the --history-file option, which set SOURCES_FILE instead of HISTORY_FILE.
Companion: php/phd#261 (adds genphdfiles.php).
Do not merge before the build pipeline calls
php phd/genphdfiles.php doc-base/temp/phd-conf.json, otherwise the manual would build without version banners.