[Sync EN] Clarify Argon2 memory_cost and time_cost units in password docs - #992
Open
lacatoire wants to merge 1 commit into
Open
[Sync EN] Clarify Argon2 memory_cost and time_cost units in password docs#992lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
…arifications EN-Revision updated: - constants.xml: 66aff414 -> 6cc48aed - password-hash.xml: 5003a6ea -> 6cc48aed Changes: - Fill in PASSWORD_BCRYPT_DEFAULT_COST description (simpara x2) - Clarify time_cost as iteration count (not duration) - Fix memory_cost unit from bytes to kibibytes (KiB) - Clarify PASSWORD_ARGON2_DEFAULT_TIME_COST as iteration count - Convert para to simpara where EN changed structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #973
Update EN-Revision to
6cc48aed6f887bdabf09c568f854099f9c74e017for bothreference/password/constants.xmlandreference/password/functions/password-hash.xml.Changes mirroring the EN commit:
constants.xml:
PASSWORD_BCRYPT_DEFAULT_COST: fill in previously empty description (uses<simpara>as in EN)time_costoption: clarify as "number of iterations (pasadas)" instead of "maximum duration"PASSWORD_ARGON2_DEFAULT_MEMORY_COST: correct unit from "bytes" to "kibibytes (KiB)"; convert<para>to<simpara>PASSWORD_ARGON2_DEFAULT_TIME_COST: clarify as "number of iterations (pasadas)" instead of "time"; convert<para>to<simpara>password-hash.xml:
time_costoption: same clarification as above; convert<para>to<simpara>