Skip to content

fix: getallheaders() must return request headers #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dunglas merged 2 commits into from
May 8, 2024
Merged

fix: getallheaders() must return request headers #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2985c78
fix: getallheaders() must return request headers
dunglas May 8, 2024
d4af65c
cs
dunglas May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frankenphp.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ function frankenphp_request_headers(): array {}
function apache_request_headers(): array {}

/**
* @alias frankenphp_response_headers
* @alias frankenphp_request_headers
*/
function getallheaders(): array {}

Expand Down
4 changes: 2 additions & 2 deletions frankenphp_arginfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/* This is a generated file, edit the .stub.php file instead.
* Stub hash: 467f1406e17d3b8ca67bba5ea367194e60d8dd27 */
* Stub hash: 05ebde17137c559e891362fba6524fad1e0a2dfe */

ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_frankenphp_handle_request, 0, 1,
_IS_BOOL, 0)
Expand Down Expand Up @@ -47,7 +47,7 @@ static const zend_function_entry ext_functions[] = {
ZEND_FALIAS(apache_request_headers,
frankenphp_request_headers,
arginfo_apache_request_headers)
ZEND_FALIAS(getallheaders, frankenphp_response_headers,
ZEND_FALIAS(getallheaders, frankenphp_request_headers,
arginfo_getallheaders)
ZEND_FE(frankenphp_response_headers,
arginfo_frankenphp_response_headers)
Expand Down