Fix rendering of attribute constants#249
Merged
kocsismate merged 2 commits intophp:masterfrom Mar 19, 2026
Merged
Conversation
$this->cchunk["fieldsynopsis"]["modifier"] was not set for atrributes due to the early return, but this value is needed in order to be able to decide if the fieldsynopsis refers to a constant or a property at https://github.com/php/phd/blob/d7f700463918a466705e92b4bfd4df0afa39d944/phpdotnet/phd/Package/Generic/XHTML.php#L1608
Member
|
Could you add a test file? :) |
kocsismate
force-pushed
the
fix-attribute-const-rendering
branch
3 times, most recently
from
fa2280b to
eb1b0d2
Compare
kocsismate
force-pushed
the
fix-attribute-const-rendering
branch
from
eb1b0d2 to
b79ab5f
Compare
Member
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
makes sense as far as I understand it, but I don't fully understand it and haven't interacted with the phd system before, so not confident enough to actually approve it
Girgias
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$this->cchunk["fieldsynopsis"]["modifier"] was not set for atrributes due to the early return, but this value is needed in order to be able to decide if the fieldsynopsis refers to a constant or a property at
phd/phpdotnet/phd/Package/Generic/XHTML.php
Line 1608 in d7f7004