Skip to content

Reflection(Class)Constant::__toString() should print booleans as booleans #22684

Description

@DanielEScherzer
<?php

echo new ReflectionConstant('true');
echo new ReflectionConstant('false');

class Demo {
    public const MY_TRUE = true;
    public const MY_FALSE = false;
    
    public $true = true;
    public $false = false;
}
echo new ReflectionClassConstant(Demo::class, 'MY_TRUE');
echo new ReflectionClassConstant(Demo::class, 'MY_FALSE');
echo new ReflectionProperty(Demo::class, 'true');
echo new ReflectionProperty(Demo::class, 'false');

function demo($t = true, $f = false) {}
echo new ReflectionFunction('demo');

shows:

Constant [ <persistent> bool TRUE ] { 1 }
Constant [ <persistent> bool FALSE ] {  }
Constant [ public bool MY_TRUE ] { 1 }
Constant [ public bool MY_FALSE ] {  }
Property [ public $true = true ]
Property [ public $false = false ]
Function [ <user> function demo ] {
  @@ /in/5nqGe 18 - 18

  - Parameters [2] {
    Parameter #0 [ <optional> $t = true ]
    Parameter #1 [ <optional> $f = false ]
  }
}

booleans in constants should be true or false, not 1 or (missing)
Marking as a feature request since this is a behavior change and shouldn't be applied to released versions

Metadata

Metadata

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions