Skip to content

Implement overloaded function deprecations for PHP 8.4 - part 1 #12728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 4, 2023
Merged

Implement overloaded function deprecations for PHP 8.4 - part 1 #12728

merged 7 commits into from
Dec 4, 2023

Conversation

@kocsismate
Copy link
Member

@kocsismate kocsismate commented Nov 19, 2023

@kocsismate kocsismate marked this pull request as draft November 19, 2023 21:22
@kocsismate kocsismate force-pushed the overloaded-func-deprecations branch from b1f4558 to 9ec6c7b Compare November 20, 2023 09:25
@kocsismate kocsismate force-pushed the overloaded-func-deprecations branch from 9ec6c7b to cdc79c8 Compare November 20, 2023 10:34
@kocsismate kocsismate force-pushed the overloaded-func-deprecations branch 2 times, most recently from 0e61a3c to fa77a8f Compare November 20, 2023 20:06
@kocsismate kocsismate marked this pull request as ready for review November 20, 2023 20:07
@kocsismate kocsismate force-pushed the overloaded-func-deprecations branch from fa77a8f to 0729d51 Compare November 20, 2023 21:00
devnexen
devnexen reviewed Nov 20, 2023
View reviewed changes
Girgias
Girgias reviewed Nov 21, 2023
View reviewed changes
derickr
derickr reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer there to be a separate PR per extension. Or at least for the ext/date part.

@kocsismate
Copy link
Member Author

kocsismate commented Nov 22, 2023 •
edited
Loading

I think I would prefer there to be a separate PR per extension. Or at least for the ext/date part.

@derickr I committed all the different changes into separate commits. So you can review the relevant part for you at 1840f44

@kocsismate kocsismate force-pushed the overloaded-func-deprecations branch 3 times, most recently from a7381d9 to 17a8882 Compare November 25, 2023 13:42
@kocsismate kocsismate force-pushed the overloaded-func-deprecations branch from 17a8882 to ea7865b Compare November 26, 2023 19:26
Girgias
Girgias approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intl, LDAP, and Reflection LGTM.

@kocsismate kocsismate merged commit 688c6f3 into php:master Dec 4, 2023
@kocsismate kocsismate deleted the overloaded-func-deprecations branch December 4, 2023 21:28
This was referenced Feb 3, 2024
Merged
Merged
Merged
@jrfnl jrfnl mentioned this pull request Feb 11, 2024
Merged
@jrfnl jrfnl mentioned this pull request Aug 14, 2024
Merged
This was referenced Oct 31, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derickr derickr derickr left review comments

@devnexen devnexen devnexen left review comments

@Girgias Girgias Girgias approved these changes

@ndossche ndossche Awaiting requested review from ndossche

Assignees

No one assigned

Labels

Extension: date Extension: intl Extension: ldap Extension: pgsql Extension: reflection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kocsismate @derickr @devnexen @Girgias