random: Clean up implementation of PCG's and Xoshiro's constructor #13106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_construct() This is for consistency with xoshiro256**'s constructor.
Instead of hardcoding struct names, or even sizes, we can just determine the actual size of the target structure using sizeof().
Girgias
approved these changes
Jan 9, 2024
|
|
||
| if (seed_is_null) { | ||
| if (php_random_bytes_throw(&state->state, sizeof(php_random_uint128_t)) == FAILURE) { | ||
| if (php_random_bytes_throw(&state->state, sizeof(state->state)) == FAILURE) { |
Member
There was a problem hiding this comment.
I'm assuming this is determined at compile time because the compiler knows the struct field type.
Member
Author
There was a problem hiding this comment.
sizeof is always compile time.
Member
There was a problem hiding this comment.
That is technically incorrect sizeof of a VLA is a runtime construct. :)
Member
Author
There was a problem hiding this comment.
TIL, but VLA are terrible anyway 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Planning to merge this using “Rebase and merge”, to keep the original commits. Bundling it in the same PR for ease of review.