zend_operators: Remove _zval_get_*() PHP 7.2 compatibility macros
#20152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have been unused for long enough and just pollute the symbol namespace.
Girgias
approved these changes
Oct 12, 2025
DanielEScherzer
approved these changes
Oct 14, 2025
UPGRADING.INTERNALS
Outdated
| added, given the primary flags were running out of bits. | ||
| . The zval_is_true() alias of zend_is_true() has been removed. Call | ||
| zend_is_true() directly instead. | ||
| . The `_zval_get_*()` compatibility macros for PHP 7.2 have been removed |
There was a problem hiding this comment.
I would suggest listing the exact macros that are removed, e.g. for people who are trying to search for the old names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been unused for long enough and just pollute the symbol namespace.