Zend: remove zend_set_hash_symbol() API #20413
Merged
+1
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unused both within php-src and a SourceGraph search returned 0 results
TimWolla
approved these changes
Nov 7, 2025
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
This seems easy enough to replicate with just doing a loop manually and avoids varargs (and removes a TODO comment). Thus LGTM.
ndossche
approved these changes
Nov 7, 2025
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
The API also is a bit weird in the sense it talks about symbol tables, but doesn't use the symbol table update functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unused both within php-src and a SourceGraph search returned 0 results