Generate C enums from internal enums, introduce Z_PARAM_ENUM() #20917
Conversation
|
|
||
| static zend_always_inline zend_long zend_enum_fetch_case_id(zend_object *zobj) | ||
| { | ||
| ZEND_ASSERT(zobj->ce->ce_flags & ZEND_ACC_ENUM); |
There was a problem hiding this comment.
This assert is redundant with the one in zend_enum_obj_from_obj(). I also don't see how it could help with codegen.
There was a problem hiding this comment.
I though about this when adding this assert, but if we consider functions as opaque APIs, we don't know that zend_enum_obj_from_obj() has redundant asserts.
There was a problem hiding this comment.
That is fair, but in this case it is probably reasonable to expect zend_enum_obj_from_obj() to do the verification (if necessary), since that's the purpose of the function, especially since a failed assert is always a programmer error.
There was a problem hiding this comment.
No particularly strong feelings either way, though.
There was a problem hiding this comment.
The _decl files should be listed in .gitattributes as linguist-generated -diff.
There was a problem hiding this comment.
Agreed. I've added **/*_decl.h, but this could accidentally match unrelated files. I'm hesitating to use another name that would be less likely to match unrelated files, such as {$ext}_arginfo_decl.h.
arnaud-lb
force-pushed
the
enum-c-enum
branch
from
aad476a to
734389e
Compare
arnaud-lb
force-pushed
the
enum-c-enum
branch
from
0b7ca66 to
adfa289
Compare
|
Nice approach. How will ADTs be handled? |
|
@iluuu1994 yes this should work. Alternatively it's possible to use |
arnaud-lb
requested review from
DanielEScherzer,
SakiTakamachi,
bukka,
devnexen,
dstogov,
kocsismate,
ndossche and
zeriyoshi
as code owners
The compiler should now be able to tell us if we forget one case
| # include "php.h" | ||
| # include "php_random_csprng.h" | ||
| # include "php_random_uint128.h" | ||
| # include "random_decl.h" |
There was a problem hiding this comment.
Should the generated headername maybe be prefixed with php_ ?
4 participants
Update
gen_stubs.phpto generate C enums from internal enums. Enum values can be compared to the result ofzend_enum_fetch_case_id(zend_object*).The generated enums are added to separate files named
{$extensionName}_decl.h(one for each extension declaring some enums), so that it's possible to include these from anywhere._arginfo.hfiles would generate warnings if we tried to include them in a compilation unit that doesn't call theregister_{$class}functions, for instance.Introduce
Z_PARAM_ENUM()(similarly to #20898).cc @TimWolla