Open
Conversation
LamentXU123
requested review from
Girgias,
NattyNarwhal,
SakiTakamachi,
TimWolla,
bukka,
derickr,
devnexen,
dstogov,
kocsismate and
ndossche
as code owners
github-actions
bot
added
Extension: openssl
Extension: intl
Extension: bz2
Extension: calendar
Extension: date
Extension: enchant
Extension: exif
Extension: ffi
Extension: gd
Extension: odbc
Extension: opcache
Extension: pcntl
Extension: pcre
Extension: pdo_firebird
Extension: pgsql
Extension: session
Extension: sockets
Extension: sqlite3
labels
github-actions
bot
added
Extension: standard
Extension: xml
Extension: zlib
Extension: uri
labels
TimWolla
requested changes
Mar 21, 2026
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
This is touching bundled libraries (e.g. uriparser).
Member
|
ext/gd/libgd needs to be reverted still. |
LamentXU123
force-pushed
the
fix-unreachable-break
branch
from
5af1a80 to
b3bd5bf
Compare
…3/php-src into fix-unreachable-break
devnexen
approved these changes
Mar 21, 2026
Member
devnexen
left a comment
devnexen
left a comment
There was a problem hiding this comment.
gd, pcntl, sockets ... I m all to finish once and for all with this "topic" anyway :)
iluuu1994
approved these changes
Mar 21, 2026
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Looks correct. Code churn, so I'll let other people decide whether this should be merged. If so, please do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After looking at #21481 and #21482 I run a script to search and delete all the occurrence in /ext