Skip to content

random: Drop leading _ from struct names#21856

Merged
TimWolla merged 1 commit intophp:masterfrom
TimWolla:random-struct-underscore
Apr 23, 2026
Merged

random: Drop leading _ from struct names#21856
TimWolla merged 1 commit intophp:masterfrom
TimWolla:random-struct-underscore

Conversation

@TimWolla
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinions

Copy link
Copy Markdown
Member

@ndossche ndossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In favor of doing this on the whole code base because names starting with an underscore are reserved.

@TimWolla
Copy link
Copy Markdown
Member Author

TimWolla commented Apr 23, 2026

In favor of doing this on the whole code base

Yes. But with the amount of typedefs and forward declarations that isn't exactly trivial, so I figured I'd at least update the stuff I officially maintain to start somewhere.

@TimWolla TimWolla merged commit 11f0288 into php:master Apr 23, 2026
19 checks passed
@TimWolla TimWolla deleted the random-struct-underscore branch April 24, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants