tree-wide: Replace XtOffsetOf by its definition#21899
Merged
TimWolla merged 1 commit intophp:masterfrom Apr 28, 2026
Merged
Conversation
`offsetof()` is in `stddef.h` and thus always available. The extra macro is an unnecessary layer of indirection.
TimWolla
requested review from
DanielEScherzer,
Girgias,
NattyNarwhal,
SakiTakamachi,
adoy,
bukka,
derickr,
devnexen,
dstogov,
kamil-tekiela,
kocsismate and
zeriyoshi
as code owners
github-actions
Bot
added
Extension: openssl
Category: Engine
Extension: intl
Extension: bcmath
Extension: curl
Extension: date
Extension: dba
Extension: dom
Extension: enchant
Extension: fileinfo
Extension: ftp
Extension: gd
Extension: gmp
Extension: hash
Extension: ldap
Extension: mysqli
Extension: odbc
labels
github-actions
Bot
added
Extension: simplexml
Extension: snmp
Extension: soap
Extension: sockets
Extension: spl
Extension: sqlite3
Extension: standard
Extension: sysvmsg
Extension: sysvsem
Extension: sysvshm
Extension: tidy
Extension: xml
Extension: xmlreader
Extension: xmlwriter
Extension: xsl
Extension: zend_test
Extension: zip
Extension: zlib
SAPI: phpdbg
Category: Optimizer
Extension: random
ABI break
Extension: uri
labels
DanielEScherzer
approved these changes
Apr 28, 2026
Member
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
okay for ext/reflection (assuming CI passes)
SakiTakamachi
approved these changes
Apr 28, 2026
Member
SakiTakamachi
left a comment
SakiTakamachi
left a comment
There was a problem hiding this comment.
I first looked at Zend, BCMath, and PDO. These look good to me.
Girgias
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
offsetof()is instddef.hand thus always available. The extra macro is an unnecessary layer of indirection.