Skip to content

zend_ast: Clean up zend_ast_export_quoted_str()#22393

Merged
TimWolla merged 2 commits into
php:masterfrom
TimWolla:zend-ast-export-quoted-str-cleanup
Jun 21, 2026
Merged

zend_ast: Clean up zend_ast_export_quoted_str()#22393
TimWolla merged 2 commits into
php:masterfrom
TimWolla:zend-ast-export-quoted-str-cleanup

Conversation

@TimWolla

Copy link
Copy Markdown
Member

Following #22350.


@iliaal FYI: Pointers should be const where possible and variables should have as small scope as possible.

@iliaal iliaal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. FYI zend_ast_export_qstr() right above still has the separate size_t i; declaration if you want to fold the same change into this one.

@TimWolla TimWolla force-pushed the zend-ast-export-quoted-str-cleanup branch from 321a32e to 1d63633 Compare June 21, 2026 21:29
@TimWolla

Copy link
Copy Markdown
Member Author

FYI zend_ast_export_qstr() right above still has the separate size_t i; declaration if you want to fold the same change into this one.

Makes sense. I've also aligned the functions further by adding a local c to zend_ast_export_quoted_str() instead of keeping the explicit cast in the if().

@TimWolla TimWolla merged commit a7a3a5f into php:master Jun 21, 2026
18 checks passed
@TimWolla TimWolla deleted the zend-ast-export-quoted-str-cleanup branch June 22, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants