zend_ast: Clean up zend_ast_export_quoted_str()#22393
Merged
TimWolla merged 2 commits intoJun 21, 2026
Merged
Conversation
…str()` Following php#22350.
iliaal
approved these changes
Jun 21, 2026
iliaal
left a comment
Contributor
There was a problem hiding this comment.
Makes sense. FYI zend_ast_export_qstr() right above still has the separate size_t i; declaration if you want to fold the same change into this one.
321a32e to
1d63633
Compare
Member
Author
Makes sense. I've also aligned the functions further by adding a local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #22350.
@iliaal FYI: Pointers should be
constwhere possible and variables should have as small scope as possible.