Skip to content

streams: call php_stream_wrapper_warn calls checking REPORT_ERRORS is set - #22965

Merged
Girgias merged 1 commit into
php:masterfrom
Girgias:2026-07-drop-useless-report-error-check
Jul 31, 2026
Merged

streams: call php_stream_wrapper_warn calls checking REPORT_ERRORS is set#22965
Girgias merged 1 commit into
php:masterfrom
Girgias:2026-07-drop-useless-report-error-check

Conversation

@Girgias

@Girgias Girgias commented Jul 31, 2026

Copy link
Copy Markdown
Member

As the underlying function already checks that REPORT_ERRORS is set in the options parameter.

… REPORT_ERRORS

As the underlying function already checks this
@Girgias
Girgias marked this pull request as ready for review July 31, 2026 10:50
@Girgias
Girgias requested a review from bukka as a code owner July 31, 2026 10:50
@Girgias Girgias changed the title streams: call php_stream_wrapper_warn calls without checking options streams: call php_stream_wrapper_warn calls checking REPORT_ERRORS is set Jul 31, 2026
@Girgias
Girgias merged commit e2d54c2 into php:master Jul 31, 2026
18 checks passed
@Girgias
Girgias deleted the 2026-07-drop-useless-report-error-check branch July 31, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant