tests: Allow overriding TEST_PHP_EXECUTABLE for FPM SAPI - #23087
Merged
Conversation
The test suite derives the path to php-fpm from TEST_PHP_EXECUTABLE. This fails on custom build directory layouts, leading to skipping all php-fpm related tests. Users can provide TEST_PHP_FPM_EXECUTABLE for a custom binary path; if this is unset, we'll fall back to TEST_PHP_EXECUTABLE instead.
Member
|
Thank you @lotharsm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suite derives the path to php-fpm from TEST_PHP_EXECUTABLE. This fails on custom build directory layouts, leading to skipping all php-fpm related tests.
Users can provide TEST_PHP_FPM_EXECUTABLE for a custom binary path; if this is unset, we'll fall back to TEST_PHP_EXECUTABLE instead.
See gentoo/gentoo#46637 (comment) for reference.