ext/gd: Fix two external libgd tests - #23138
Merged
Merged
Conversation
Contributor
Author
|
Okay, the remaining ones are trickier, e.g. simply reverting the tests won't necessarily work, because the infra around it seemed to change. Might need a bit more time to investigate though. |
devnexen
approved these changes
Aug 9, 2026
Member
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After intruducing
php-src/ext/gd/gd.c
Lines 302 to 306 in bf5141c
the expected output of the bundled libgd matches the expected output when using an external libgd.
Without this change, the test suite fails when using external gd.
This leaves us with the following test failures, all with external gd:
ext/gd/tests/bug73291.phptis related to differences in the algorithm between the current stable libgd-2.3.3 and the bundled 2.4 pre-release, so we either need to split this into a new _external test, which will cause issues when distributions eventually start to ship a future 2.4 release, or we need to guard this behind a version check.See gentoo/gentoo#46580 (comment) for more context.
Not sure about the other two failing tests though, but since they also got touched when updating the bundled libgd to 2.4pre, I bet it is the same issue.