Zend: remove Z_PARAM_FUNC_OR_NULL_WITH_ZVAL() - #23234
Merged
Merged
Conversation
And related Z_PARAM_GET_PREV_ZVAL() These were introduced in php@1179622 to simplify memory management. But this is no longer relevant (well never was as one could have grabbed the zval from the FCI) since the refactoring to only use FCCs in php@0e5d654 The following SourceGraph searches confirm there is no usage: - https://sourcegraph.com/search?q=context:global+Z_PARAM_FUNC_OR_NULL_WITH_ZVAL&patternType=keyword&sm=0 - https://sourcegraph.com/search?q=context:global+Z_PARAM_GET_PREV_ZVAL&patternType=keyword&sm=0
arnaud-lb
approved these changes
Aug 12, 2026
DanielEScherzer
approved these changes
Aug 12, 2026
DanielEScherzer
left a comment
DanielEScherzer
left a comment
Member
There was a problem hiding this comment.
makes sense to me, should include UPGRADING.INTERNALS for any private uses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And related Z_PARAM_GET_PREV_ZVAL()
These were introduced in 1179622 to simplify memory management.
But this is no longer relevant (well never was as one could have grabbed the zval from the FCI) since the refactoring to only use FCCs in 0e5d654
The following SourceGraph searches confirm there is no usage: