Fix Calendar::createInstance double-free of the adopted TimeZone - #23320
Open
iliaal wants to merge 1 commit into
Open
Fix Calendar::createInstance double-free of the adopted TimeZone#23320iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
ICU 57+ Calendar::createInstance wraps the TimeZone in a LocalPointer and deletes it when the calendar cannot be created. PHP deleted the same pointer again on that failure. Drop the extra delete in createInstance and fromDateTime.
devnexen
reviewed
Aug 16, 2026
| @@ -0,0 +1,24 @@ | |||
| --TEST-- | |||
Member
There was a problem hiding this comment.
this test is kinda of useless, I would suggest to drop it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ICU 57+ Calendar::createInstance adopts the TimeZone and frees it if the calendar cannot be created. createInstance and fromDateTime deleted that pointer again on failure.