Close a UConverter that fails callback install - #23347
Closed
iliaal wants to merge 1 commit into
Closed
Conversation
ucnv_open() can succeed and php_converter_set_callbacks() can still fail on a UConverter subclass. The converter was neither stored nor closed. Close it on that return. The non-subclass path short-circuits set_callbacks; transcode passes a NULL object and never installs callbacks.
LamentXU123
requested changes
Aug 18, 2026
LamentXU123
left a comment
LamentXU123
left a comment
Member
There was a problem hiding this comment.
Could you provide an ICU version or a reproducer where either callback setter changes a successful UErrorCode into a failure ?
this branch appears unreachable IMO and I dont see the reason fixing it.
Member
Author
|
No. Those setters only return if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ucnv_open() can succeed and php_converter_set_callbacks() can still fail on a UConverter subclass. The converter was neither stored nor closed. Close it on that return. The default class skips callback install; transcode passes a NULL object.