ext/standard: Adds and modifies XFAIL tests for filter bucket leaks - #23440
ext/standard: Adds and modifies XFAIL tests for filter bucket leaks#23440NickSdot wants to merge 1 commit into
Conversation
|
#23267 is the master version of this; GH-20058 is 8.3. It already touches both files you re-gated and just drops their XFAIL, so rebasing on it removes those two hunks. On the new tests, measured on a debug NTS master build: The block also ends in an unconditional 22 lines of SKIPIF copied into four files is heavy for something you want to delete again shortly. The rest of the tree gates these with |
I wanted to fix two
warn: XFAIL section but test passesbut found #20058 which already attempts fixing the leaks; don't want to open an overlapping one. However, the PR is already a bit older -- currently builds without leak detection warn becauseXFAILis too broad. So here we change to useSKIPIFto "xfail", "xleak", or skip only where relevant so that we for the time being have no warnings where no leaks can be detected and tests pass. Additionally, two tests for related issues that surfaced were added (also mentioned in #20058 (comment)) .Should this target 8.4 (20058 still targets 8.3)?
cc @Girgias the two modified tests were added by you, are you okay with this change?
cc @iliaal would you want to look at the two added tests?