Show the do-not-translate and broken XML statuses - #68
Open
lacatoire wants to merge 1 commit into
Open
Conversation
Two pages following the shape of the existing ones, their menu entries, and the two statuses in $TRANSLATION_STATUSES. Files marked do not translate are kept out of the completion totals, matching doc-base, so no translation sees its rate drop for files it is not expected to have. Their share of a total they are not part of shows as n/a. Other statuses are displayed as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Front end for the two statuses added in php/doc-base#334.
Once that one is deployed, files carrying the new statuses land in the
filestable and count in the denominator ofget_lang_stats(), but show up in no row of the file summary. The percentages then stop adding up to 100, with nothing on the page saying why. Until it is deployed this PR is inert: the queries just return nothing.It adds two pages,
p=brokenfilesandp=donottranslate, built on the same shape as the existingmisstagsandoldfilespages, plus their menu entries and the two statuses in$TRANSLATION_STATUSES.Files marked do not translate are listed but left out of the completion totals, to match
scripts/revcheck.phpandgenrevdb.phpin doc-base: a translation should not see its rate drop for files it is not expected to have. Their share of a total they are not part of shows asn/a. Other statuses are displayed as before. If that is the wrong call on this side, it is a small change to make.Checked locally with the built-in server, against a database built from doc-fr and doc-ru.
The file summary gains the two rows:
Broken XML lists
chmonly/search.xmlwith its parse error:Do not translate lists the marked files: