Fix PHP 8.4 property hooks example not being full width when wrapped #1522
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodorejb
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
|
🚀 Regression report for commit e508d9a is at https://web-php-regression-report-pr-1522.preview.thephp.foundation |
|
🚀 Preview for commit e508d9a can be found at https://web-php-pr-1522.preview.thephp.foundation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously overriding the display from
flextotable-cellcaused the width to be no wider than the contents:It's not very noticeable in this case since the contents are almost as wide as the page, but if we want to top-align other code blocks where the contents aren't as wide, the issue becomes much more obvious.