Skip to content

Conversation

@Girgias
Copy link
Member

@Girgias Girgias commented Nov 26, 2020

Have done this in a hurry so a quick review would be appreciated. :)

@pronskiy
Copy link
Member

@Girgias need to add French to $LANGUAGES in include/layout.inc.

    $LANGUAGES = array(
        'en'    => 'English',
        'pt_BR' => 'Brazilian Portuguese',
+        'fr' => 'French',
        'de'    => 'German',
        'ru'    => 'Russian',
    );

@Girgias Girgias force-pushed the french-translation branch 2 times, most recently from db5992a to 13b99d7 Compare November 26, 2020 16:39
Translations updated by abusing Google Translated and my limited knowledge of said languages
Copy link

@azjezz azjezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just a few issues

<h2 class="php8-h2" id="constructor-property-promotion">
Constructor property promotion
<a class="php8-rfc" href="https://wiki.php.net/rfc/constructor_promotion">RFC</a>
<a class="php8-rfc" href="https://wiki.php.net/rfc/constructor_promotion">RFC</a> <a class="php8-rfc" href="/manual/fr/language.oop5.decon.php#language.oop5.decon.constructor.promotion">Doc</a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a class="php8-rfc" href="https://wiki.php.net/rfc/constructor_promotion">RFC</a> <a class="php8-rfc" href="/manual/fr/language.oop5.decon.php#language.oop5.decon.constructor.promotion">Doc</a>
<a class="php8-rfc" href="https://wiki.php.net/rfc/constructor_promotion">RFC</a> <a class="php8-rfc" href="/manual/en/language.oop5.decon.php#language.oop5.decon.constructor.promotion">Doc</a>

<h2 class="php8-h2" id="union-types">
Union types
<a class="php8-rfc" href="https://wiki.php.net/rfc/union_types_v2">RFC</a> <a class="php8-rfc" href="/manual/en/language.types.declarations.php#language.types.declarations.union">Doc</a>
<a class="php8-rfc" href="https://wiki.php.net/rfc/union_types_v2">RFC</a> <a class="php8-rfc" href="/manual/fr/language.types.declarations.php#language.types.declarations.union">Doc</a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a class="php8-rfc" href="https://wiki.php.net/rfc/union_types_v2">RFC</a> <a class="php8-rfc" href="/manual/fr/language.types.declarations.php#language.types.declarations.union">Doc</a>
<a class="php8-rfc" href="https://wiki.php.net/rfc/union_types_v2">RFC</a> <a class="php8-rfc" href="/manual/en/language.types.declarations.php#language.types.declarations.union">Doc</a>

<h2 class="php8-h2" id="match-expression">
Match expression
<a class="php8-rfc" href="https://wiki.php.net/rfc/match_expression_v2">RFC</a>
<a class="php8-rfc" href="https://wiki.php.net/rfc/match_expression_v2">RFC</a> <a class="php8-rfc" href="/manual/fr/control-structures.match.php">Doc</a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a class="php8-rfc" href="https://wiki.php.net/rfc/match_expression_v2">RFC</a> <a class="php8-rfc" href="/manual/fr/control-structures.match.php">Doc</a>
<a class="php8-rfc" href="https://wiki.php.net/rfc/match_expression_v2">RFC</a> <a class="php8-rfc" href="/manual/en/control-structures.match.php">Doc</a>

<div class="php8-compare">
<h2 class="php8-h2" id="union-types">
Types d'union
<a class="php8-rfc" href="https://wiki.php.net/rfc/union_types_v2">RFC</a> <a class="php8-rfc" href="/manual/en/language.types.declarations.php#language.types.declarations.union">Doc</a>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a class="php8-rfc" href="https://wiki.php.net/rfc/union_types_v2">RFC</a> <a class="php8-rfc" href="/manual/en/language.types.declarations.php#language.types.declarations.union">Doc</a>
<a class="php8-rfc" href="https://wiki.php.net/rfc/union_types_v2">RFC</a> <a class="php8-rfc" href="/manual/fr/language.types.declarations.php#language.types.declarations.union">Doc</a>

@Girgias
Copy link
Member Author

Girgias commented Nov 26, 2020

Had them fixed locally, but as I can't yet push to the git repo due to karma propagation I'll force push it :)

@Girgias
Copy link
Member Author

Girgias commented Nov 26, 2020

just when I started complaning merged as f240733

@Girgias Girgias closed this Nov 26, 2020
@Girgias Girgias deleted the french-translation branch November 26, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants