Skip to content

Conversation

@nikic
Copy link
Member

@nikic nikic commented May 25, 2021

This creates an empty issue with the following body:

From manual page: https://php.net/$id

---

@nikic nikic requested a review from cmb69 May 25, 2021 14:04
@saundefined
Copy link
Member

@nikic, doc-ru and doc-tr have enabled issues too.
Maybe use the lang-depended "report a bug" link and English as default?

e.g.
$issuesEnabled = ['ru', 'tr'];
$bugsUrl = 'https://github.com/php/doc-' . (in_array($repo, $issuesEnabled, true) ? $repo :  'en') . '/issues/new?body=' . urlencode("From manual page: https://php.net/$id\n---\n");

@Girgias
Copy link
Member

Girgias commented May 25, 2021

In this case we should enable issues for all doc repos, the French one doesn't have them enabled as of yet.

@nikic
Copy link
Member Author

nikic commented May 25, 2021

@saundefined I think the key question is, when somebody clicks "Report a Bug" on a translated page, how often do they want to report an error in the content (that they just happen to see in a translated version) vs how often do they want to report a translation mistake.

I think it may make more sense to point everything at doc-en and then move issues to translations if they really are about translations only.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nikic nikic merged commit ece41d3 into php:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants