Kill off XHTML #46
Kill off XHTML #46
Conversation
Upstream
Long live HTML5! =)
Last but not least
include/layout.inc
Outdated
There was a problem hiding this comment.
You are right. I will give it a closer look when I have more time this evening or tomorrow.
On the fly it looks like the second parameter of nl2br would be the solution, we can just set is_xhtml = false and it will output html.
The question is need we support for < 5.3.0?
...to use HTML5
The <tt>-tag doesn't exists anymore in HTML5
Replace <big> with <span style="font-size:1.2em"> since <big> is obsolet in HTML5
Replace <small> with <span style="font-size:0.8em"> because the definition of <small> is a complete other with HTML5
|
More feedback, deprecated/obsolet/redefined tags, problems? |
include/layout.inc
Outdated
|
Exactly as Hannes said - inline CSS is not better than |
|
Well it's nice to see that I can help :) By the way since I don't know where else I can report bugs for the website... |
|
It looks fine for me, now. I will, however, I'll leave to review it for @bjori as he is way more experienced dev than me. I'll also leave him decision on squashing commits. Answering to your question: proper place to report such bugs is bugs.php.net under category called "Website problem". I don't know if using fonts directly is desired behavior, but I wouldn't be surprised. Have a nice day. |
|
LGTM ! |
|
What will happen now? :) |
Kill off XHTML * Croydon/master: Use release_date() also in PHP4 changelog Typo Use css class instead inline style Revert "Replace <small> with <span style" Replace <small> with <span style Replace <big> with <span style.... Replace <tt> with <code> Drop support for < 5.3 from highlight_php() Finally remove XHTML from .js files Also remove XHTML from .inc files Kill off XHTML
|
my bad, I thought you had karma. |
4 participants
Replace XHTML in favor of HTML5.
No guarantee that I have found and replaced all XHTML-Tags out there in the wild, but this should be (almost) complete.
Please report any bugs which may be caused by this change, especially have a closer look on the javascript functions which manipulating the source.
Thanks =)