Skip to content

Conversation

@Sobak
Copy link
Contributor

@Sobak Sobak commented Aug 17, 2014

Read http://news.php.net/php.doc/969385115 and previous discussion for more informations about this pull request.

docs.php Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should say what is currently happening, rather I suggest we word this as though we already had removed the documentation to the archives.

Aside: "this explanation" isn't a very good link name, how about using the document title ("Documentation for PHP 4")?

@Sobak
Copy link
Contributor Author

Sobak commented Aug 17, 2014

Thank you @salathe, once again! Unfortunately, I keep forgetting about articles and make other stupid mistakes ;P

docs.php Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing this sentence and instead appending "and the PHP 4 Manual" to the following one, to become "The same applies to the PHP 3 Manual, and the PHP 4 Manual."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks :)

@php-pulls php-pulls merged commit 417e8b2 into php:master Aug 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants