Skip to content

Conversation

@Wes1262
Copy link
Contributor

@Wes1262 Wes1262 commented Apr 19, 2015

...and starting an attempt to clean this file.

...and starting an attempt to clean this file.
@morrisonlevi
Copy link
Contributor

Thanks for looking into this. I am not sure about some of the details; the callbackCalled = true; looks shady. I'm also not completely sure that this will prevent the browser's default scroll in some cases. I'll try and find some time to play with this to see how it works and if I can it to break.

@Wes1262
Copy link
Contributor Author

Wes1262 commented Apr 19, 2015

yes, because i don't know why $('html, body') was used. maybe for compatibility with some old browser. that causes the callback to be executed twice which is not what we want so for now i just prevented that to happen. clearly it's a temporary solution till i can investigate more (it's not different from previous implementation anyway)

also. i am 100% sure the approach for preventing default scrolling is correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed this because the hashchange event is not cancelable. It couldn't have ever worked

@php-pulls php-pulls merged commit 72f7d11 into php:master Jun 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants