Fix some bugs#133
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR focuses on tightening security and correctness in the web push notifications extension by improving token comparison, hardening template-to-JS data output, and simplifying version checks.
Changes:
- Use constant-time comparison for anonymous notification token validation.
- Escape/normalize values embedded into JavaScript options in the UCP webpush template (and align subscription field names/types with the JS consumer).
- Mark the NPM package as private and simplify the PHP version check.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ucp/controller/webpush.php | Switches token comparison to hash_equals for safer validation. |
| styles/all/template/ucp_notifications_webpush.html | Adds JS-context escaping and outputs numeric values as numbers; aligns subscription field naming. |
| package.json | Marks the package as "private": true. |
| migrations/add_webpush.php | Removes migration revert_data() cleanup logic (potential uninstall/revert regression). |
| ext.php | Simplifies PHP version requirement check using PHP_VERSION_ID. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
79
to
82
| ]]], | ||
| ]; | ||
| } | ||
|
|
||
| public function revert_data(): array | ||
| { | ||
| return [ | ||
| ['config.remove', ['wpn_webpush_enable']], | ||
| ['config.remove', ['wpn_webpush_vapid_public']], | ||
| ['config.remove', ['wpn_webpush_vapid_private']], | ||
| ['module.remove', ['acp', 'ACP_BOARD_CONFIGURATION', 'ACP_WEBPUSH_EXT_SETTINGS']] | ||
| ]; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.