Fix PHP7 issues with isset on $ext_config#212
Merged
DavidIQ merged 1 commit intophpbb:3.2.xfrom Apr 24, 2017
Merged
Conversation
DavidIQ
approved these changes
Apr 24, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.phpbb.com/browse/CUSTDB-732
Using
isseton the$ext_configobject returns the wrong boolean result in PHP 7. I do not understand why, it may have to do with all the magic used to access the data in $ext_config. Maybe there's a better way, I don't know but in the mean time, replacing asset with a comparison against null also solves the issue in PHP 7.Specifically these changes fix the problems where uploading a new contribution or revision fails under PHP 7.