[ticket/10073] Add a contact administrators page and refactor email forms

[nickvergessen]

The message to be displayed on top of the email form cannot be configured yet.

http://tracker.phpbb.com/browse/PHPBB3-10073
http://area51.phpbb.com/phpBB/viewtopic.php?f=84&t=39804

Replaces #210

todo

• Add option to set contact_admin_info in the ACP
• Parse contact_admin_info
• Should still display the email-link when contact page is disabled
• https://tracker.phpbb.com/browse/PHPBB3-12570

[nickvergessen]

phpBB > sniff:
FILE: /home/travis/build/phpbb/phpbb/phpBB/phpbb/message/topic_form.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
106 | ERROR | Functions must not contain multiple empty lines in a row; found
    |       | 2 empty lines
    |       | (Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines)
--------------------------------------------------------------------------------

[Elsensee]

I guess you should use $user->lang(); here.

[nickvergessen]

Added the ACP module.
Should be ready now

[Nicofuma]

sendpassword?

[nickvergessen]

copied the wrong link

[naderman]

Yay :) @Marshalrusty can you give this a test and see if you're happy with how it works?

[bantu]

Hmm. Should probably get this from the container. It is a service.

[Marshalrusty]

A couple of things I noticed.

If the board is disabled, the contact page is inaccessible. This is probably a usecase for when it's quite useful, so I'd make it available in as many cases as possible.

Also, on the ACP config page, "disable BBCode" and "DIsable smilies" are checked by default.

I would also suggest renaming “Contact Us” settings to "Contact page settings" (without the quotes) to match the rest of the options there.

[iMattPro]

Since the BBCode editor code from the acp_user_signature.html is being duplicated here, maybe now would be a good time to split the BBCode editor code out into its own acp_posting_buttons.html file, which could be included here and in acp_users_signature.html (and then extensions could use it more easily in the ACP as well).

[naderman]

I'd be very much in favour of doing that.

[nickvergessen]

Everything should be fixed. But it requires https://tracker.phpbb.com/browse/PHPBB3-12570 to be fixed

[nickvergessen]

Rebased onto develop-ascraeus, so this should be ready for another review

[nickvergessen]

Rebased onto develop-ascraeus, so this should be ready for another review

[EXreaction]

I thought we had decided (for the fourth or fifth time now) to not add more features into 3.1 and instead put them into 3.2...

[Marshalrusty]

As long as you agree to start answering phpBB.com email, I have no objections to this waiting until 3.2 :)

[n-aleha]

I kinda have the same problem. Contact via email is not the way to go nowadays, at least should not be the only way.
Sure, phpBB needs a few things here and there and now is not the time for them, but I do not want to imagine that phpBB will introduce a new version which doesn't include a component such as this.

[EXreaction]

I do not think this should be put into the memberlist, even if the functionality is similar.

[EXreaction]

All this does is send the administrator an email, so I don't know what either of you are trying to argue for.

If another developer wants to continue the never ending feature creep into 3.1, they can feel free to merge this, I've already voiced my opinion.

[nickvergessen]

@EXreaction there is now a way to mail the admins so people dont use the copyright link and end up sending us the email instead.

[Marshalrusty]

The previous two things I mentioned are still there, it seems. To quote:

1. If the board is disabled, the contact page is inaccessible. This is probably a usecase for when it's quite useful, so I'd make it available in as many cases as possible.
2. Also, on the ACP config page, "disable BBCode" and "DIsable smilies" are checked by default.

Additionally, the button would probably be better as "Send Message" or "Send Email" rather than just "Email".

Otherwise, this can be merged.

[Marshalrusty]

Relevant: https://www.phpbb.com/community/viewtopic.php?f=46&t=2246416

[nickvergessen]

1. If the board is disabled, the contact page is inaccessible. This is probably a usecase for when it's quite useful, so I'd make it available in as many cases as possible.

This works for me (did you fetch the newest changes before testing it again? ;) )

The check boxes are fixed

Button text has been updated

[Marshalrusty]

I tested this when the install directory was there. It works fine when the board is disabled, but not when the install directory is there. If it's not too difficult to fix, I'd fix it. Otherwise, ignore it.

Check boxes work as expected on new installs. Everything else is fine.

Thanks!

[nickvergessen]

@Marshalrusty I'm not sure whether we should allow it when the board has install/ available.
This mostly means that an updated is performed just now.
Even admins can not access the board then atm (only install/).

[naderman]

Yeah let's just leave that, I'll merge this then :-)