[ticket/8064] Forum author sort using username_clean#2387
Merged
naderman merged 1 commit intophpbb:developfrom Aug 10, 2014
Merged
[ticket/8064] Forum author sort using username_clean#2387naderman merged 1 commit intophpbb:developfrom
naderman merged 1 commit intophpbb:developfrom
Conversation
nickvergessen
changed the title
phpBB/install/schemas/schema.json
Outdated
Contributor
There was a problem hiding this comment.
Header needs to be updated
Member
|
As per my comment on the ticket I think it would be better to simply modify the collation on the poster_name column and sort by that rather than sort by username_clean. Can you look into whether that is possibl? utf8_unicode_ci should work I think. |
Member
Author
|
updated to use a true sort (utf8_unicode_ci on MySQL) instead of all the other stuff |
Member
|
:-) |
Member
Author
|
rebased on develop-ascraeus |
nickvergessen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests still missing.
About the migration file, we need to fill the column
(topic_first_poster_name_clean) while updating the db but it's not easy
and the migration could take a lot of time with thousands topics.
https://tracker.phpbb.com/browse/PHPBB3-8064
PHPBB3-8064