[ticket/12509] Add an option to set the path of custom style directory (ie: email templates) for extensions#2455
Conversation
PHPBB3-12509
…nger PHPBB3-12509
PHPBB3-12509
phpBB/adm/index.php
Outdated
PHPBB3-12509
PHPBB3-12509
There was a problem hiding this comment.
If possible add the trailing slash here aswell.
Basically if it does not exist, set_custom_style() should append it
There was a problem hiding this comment.
Or if it is required without, then the method should remove it
There was a problem hiding this comment.
it's not really the name of the directory and i don't know what it is expected to be (ie: for the e-mails it's en_mail)
But it does not seem to be used anywhere else. So we should be able to change the thing to give directly the path to the directory.
There was a problem hiding this comment.
in fact name should be the name of the style (ie: prosilver) the problem is that the method is used for two usages: define a style location and define a custom template directory.
phpBB/adm/index.php
Outdated
There was a problem hiding this comment.
Missing , here and in most of the other arrays
PHPBB3-12509
There was a problem hiding this comment.
Please add the array from adm/index.php as a sample here
PHPBB3-12509
[ticket/12509] Add an option to set the path of custom style directory (ie: email templates) for extensions * Nicofuma/ticket/12509: [ticket/12509] Add example in doc block [ticket/12509] Add missing ',' in arrays [ticket/12509] Update calls to set_custom_style in forgotten places [ticket/12509] Fix path in adm/index.php [ticket/12509] Fix typo in adm/index.php [ticket/12509] Fix doc block [ticket/12509] Fix the call to set_custom_file in adm/index and messenger [ticket/12509] Update acp custom_style setter [ticket/12509] Add an option to set the path of custom file for extensions
3 participants
https://tracker.phpbb.com/browse/PHPBB3-12509
PHPBB3-12509