Skip to content

[ticket/12863] Add T_STYLES_PATH template var#2750

Closed
PayBas wants to merge 2 commits intophpbb:develop-ascraeusfrom
PayBas:ticket/12863
Closed

[ticket/12863] Add T_STYLES_PATH template var#2750
PayBas wants to merge 2 commits intophpbb:develop-ascraeusfrom
PayBas:ticket/12863

Conversation

@PayBas
Copy link
Copy Markdown
Contributor

@PayBas PayBas commented Jul 17, 2014

Lets say you want to use template inheritance, but you also want to inherit some CSS or JS files from another template.

This isn't really possible since INCLUDEJS and INCLUDECSS don't have the same tree traversal properties as INCLUDE html.

So how do we load assets from another style?

By using T_STYLES_PATH, we could make it a bit easier to load assets, since we dont have to do all the ../../../other_style/ dir walking.

https://tracker.phpbb.com/browse/PHPBB3-12863
PHPBB3-12863

@nickvergessen
Copy link
Copy Markdown
Contributor

I think we should fiy the INCLUDE* then instead of adding a template var workaround

@nickvergessen
Copy link
Copy Markdown
Contributor

Also style path work around will not work for extensions, but a fixed INCLUDE* should

@PayBas
Copy link
Copy Markdown
Contributor Author

PayBas commented Jul 17, 2014

I think these vars will come in handy, regardless of whether we fix INCLUDEJS and INCLUDECSS.

@nickvergessen
Copy link
Copy Markdown
Contributor

As per IRC, we should just fix them, adding these variables will just cause undesired workarounds for bugs we should fix.

@PayBas
Copy link
Copy Markdown
Contributor Author

PayBas commented Jul 18, 2014

Keeping T_LANG_NAME could come in handy though. For external javascript libraries for instance.

@nickvergessen
Copy link
Copy Markdown
Contributor

That is what S_USER_LANG is for

@PayBas
Copy link
Copy Markdown
Contributor Author

PayBas commented Jul 18, 2014

Ah, i guess i missed that one. I'll close this.

@PayBas PayBas closed this Jul 18, 2014
@PayBas PayBas deleted the ticket/12863 branch August 8, 2014 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants