[ticket/12863] Add T_STYLES_PATH template var#2750
Closed
PayBas wants to merge 2 commits intophpbb:develop-ascraeusfrom
Closed
[ticket/12863] Add T_STYLES_PATH template var#2750PayBas wants to merge 2 commits intophpbb:develop-ascraeusfrom
PayBas wants to merge 2 commits intophpbb:develop-ascraeusfrom
Conversation
PHPBB3-12863
PHPBB3-12863
Contributor
|
I think we should fiy the INCLUDE* then instead of adding a template var workaround |
Contributor
|
Also style path work around will not work for extensions, but a fixed INCLUDE* should |
Contributor
Author
|
I think these vars will come in handy, regardless of whether we fix INCLUDEJS and INCLUDECSS. |
Contributor
|
As per IRC, we should just fix them, adding these variables will just cause undesired workarounds for bugs we should fix. |
Contributor
Author
|
Keeping |
Contributor
|
That is what |
Contributor
Author
|
Ah, i guess i missed that one. I'll close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets say you want to use template inheritance, but you also want to inherit some CSS or JS files from another template.
This isn't really possible since INCLUDEJS and INCLUDECSS don't have the same tree traversal properties as INCLUDE html.
So how do we load assets from another style?
By using T_STYLES_PATH, we could make it a bit easier to load assets, since we dont have to do all the ../../../other_style/ dir walking.
https://tracker.phpbb.com/browse/PHPBB3-12863
PHPBB3-12863