[ticket/12931] Fix general error on user registration#2864
Merged
marc1706 merged 1 commit intophpbb:develop-ascraeusfrom Aug 10, 2014
Merged
[ticket/12931] Fix general error on user registration#2864marc1706 merged 1 commit intophpbb:develop-ascraeusfrom
marc1706 merged 1 commit intophpbb:develop-ascraeusfrom
Conversation
Member
There was a problem hiding this comment.
Should assign $config['server_name'] to $domain if check evaluates to true.
Contributor
There was a problem hiding this comment.
?: without a space
and remove the brackets
Member
There was a problem hiding this comment.
Nvm, see what nickvergessen said.
Fix "Illegal use of $_SERVER" general error on user registration when $config['server_name'] is not set. PHPBB3-12931
Contributor
Author
|
Updated #2864.. |
marc1706
added a commit
to marc1706/phpbb
that referenced
this pull request
Aug 10, 2014
[ticket/12931] Fix general error on user registration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix "Illegal use of $_SERVER" general error on user registration
when $config['server_name'] is not set.
PHPBB3-12931.