[ticket/13487] Add factory for db tool class#3275
Conversation
This allows us to split up the large file one by one easily. PHPBB3-13487
91be681 to
11b6bc5
Compare
|
Actually here we have 2 ways to that on an "easier" (using the DIC to construct the real db tools object):
I think I prefer the second solution (and by the way it could be nice to do the same think with the dbal driver) |
|
Well im going to add an array implementation which is independent from the used db, does this still work (i don't know anything about compilerpass stuff) |
|
When will this implementation be used and when will be the dbal driver dependent implementation? |
|
It will be used for generating the schema.json and for tests, |
|
I think that the array implementation should be an independent public service and requested directly when needed. |
|
Can we still ahve this little factory while we are splitting up the current db_tools file since it makes it a lot easier? |
|
I think yes but if you do that this way you have to instantiate the class manually in the factory... |
[ticket/13487] Add factory for db tool class
This allows us to split up the large file one by one easily.
https://tracker.phpbb.com/browse/PHPBB3-13487