[ticket/15605] Correct Right-Margin for ribbon image

[dnssh]

Checklist:

• Correct branch: master for new features; 3.2.x for fixes
• Tests pass
• Code follows coding guidelines: master and 3.2.x
• Commit follows commit message format

Tracker ticket (set the ticket ID to 15605):

https://tracker.phpbb.com/browse/PHPBB3-15605

[hanakin]

@dnssh we have very strict coding guidelines we are implementing for version 3.3 related to CSS we are still working on all the documentation but we are using stylelint for linting rules. have a look at the Travis results https://travis-ci.org/phpbb/phpbb/jobs/359943288#L502 if you have any questions please feel free to ask here

[hanakin]

Check the commit I left on your commit as the message needs fixed slightly

[dnssh]

Hello Sir,
@hanakin Thank you for your kind suggestion.
Pls review whether below commit has correct format

$ git commit -m "[ticket/15605] Correct Right-Margin for ribbon image

PHPBB3-15605"

Regards,
Devansh Shah

[hanakin]

@dnssh looks good

[dnssh]

Thank You @hanakin ,all the changes have been committed successfully.

[hanakin]

@dnssh ok a couple of things. First, why did you create a new ticket in the tracker? Please do not do this use the ticket that is there next time. second, all you need is a margin: 5px; auto does nothing when positioning absolutely so not sure why that's there and left and bottom have no effect so might as well simplify the amount of code.

[dnssh]

Ok thanks ,will consider these things further.

[hanakin]

@dnssh are you going to make the suggested change?

[dnssh]

OK Sir @hanakin made those suggested changes

[hanakin]

I Approve