Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure $phpbb_container is not null before trying to get anything … #5582

Merged
merged 1 commit into from Jun 19, 2019

Conversation

@paul999
Copy link
Member

commented May 3, 2019

…from the container.

PHPBB3-16043

Checklist:

  • Correct branch: master for new features; 3.2.x for fixes
  • Tests pass
  • Code follows coding guidelines: master and 3.2.x
  • Commit follows commit message format

Tracker ticket (set the ticket ID to your ticket ID):

https://tracker.phpbb.com/browse/PHPBB3-16043

@paul999 paul999 force-pushed the paul999:ticket/16043 branch 3 times, most recently from ad853c8 to f5867d4 May 3, 2019

@marc1706 marc1706 added this to the 4.0.0-a1 milestone Jun 17, 2019

@marc1706 marc1706 force-pushed the paul999:ticket/16043 branch from f5867d4 to d728d36 Jun 17, 2019

[ticket/16043] Check if not null before getting anything from the con…
…tainer

This is only happening when there is basicly an error during
init of the container.

PHPBB3-16043

@marc1706 marc1706 force-pushed the paul999:ticket/16043 branch from d728d36 to 4be13ba Jun 18, 2019

@marc1706 marc1706 merged commit 6941b39 into phpbb:master Jun 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.