[ticket/16719] Fix PHP notice/warnings on update/install - PHP 8#6167
Merged
marc1706 merged 3 commits intophpbb:prep-release-3.3.4from Apr 4, 2021
Merged
[ticket/16719] Fix PHP notice/warnings on update/install - PHP 8#6167marc1706 merged 3 commits intophpbb:prep-release-3.3.4from
marc1706 merged 3 commits intophpbb:prep-release-3.3.4from
Conversation
Contributor
Author
|
Tests are not my fault IMHO. @marc1706 |
Contributor
|
So basically you're reverting the fix back? |
Contributor
Author
|
Not really, I am removing such definition completely. Still in progress though, tomorrow I will do some test. |
Contributor
|
As far as I remember, the definition is needed until |
Contributor
Author
|
Tested fresh install and update from previous version as well.
|
Contributor
|
I guess initial issue will be back again with this patch, won't it? |
Contributor
Author
No issues here, also looking at your ticket in the tracker. Is there something else we should be aware of? https://area51.phpbb.com/phpBB/viewtopic.php?p=343201#p343201 |
added 3 commits
April 2, 2021 10:01
PHPBB3-16719
PHPBB3-16719
PHPBB3-16719
marc1706
added a commit
to marc1706/phpbb
that referenced
this pull request
Apr 4, 2021
[ticket/16719] Fix PHP notice/warnings on update/install - PHP 8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPBB3-16719
Checklist:
https://tracker.phpbb.com/browse/PHPBB3-16719