[ticket/17604] Prevent disabling teamsecurity extension

[iMattPro]

PHPBB-17604

Checklist:

• Correct branch: master for new features; 3.3.x for fixes
• Tests pass
• Code follows coding guidelines: master and 3.3.x
• Commit follows commit message format

Tracker ticket:

https://tracker.phpbb.com/browse/PHPBB-17604

[iMattPro]

The issue - the teamsecurity extension cannot be disabled without removing the ext.php from the filesystem. That file calls a trigger_error during the disable step. That causes an infinite loop when this disable-extensions-migration runs.

This is likely the cleanest fix - whitelist teamsecurity like we already do with viglink, in this migration.

Otherwise, the only other real fix I have found is more substantial (requiring changes in this file, the ACP, and the extension) :

• Replace the trigger_error in the teamsecurity extension with a thrown Exception
• Catch the Exception in this migration and silently continue
• Catch the Exception in the ACP and display the exception message