This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Test readline error is handled properly #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krakjoe
reviewed
Oct 25, 2017
| var_dump(readline("test", "test")); | ||
| ?> | ||
| --EXPECTF-- | ||
| Warning: readline() expects at most 1 parameter, 2 given in %s on line %d |
Contributor
There was a problem hiding this comment.
This appears to be an unnecessary test of ZPP
Author
There was a problem hiding this comment.
How would you recommend best to avoid this. Obviously I could suppress the error, but that seems gross, or tell it to not output errors? Unless there is another test declaration that I don't know about (probably!)
Contributor
There was a problem hiding this comment.
@liam-wiltshire see also this discussion https://externals.io/message/103886#103989 for more info about this. Thank you.
p365labs
pushed a commit
to p365labs/phptestfest-php-src
that referenced
this pull request
Nov 18, 2017
…ersions Updating PHP minor versions
Contributor
|
Closing as this is basically a ZPP failure test and we do not accept it anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assert that readline returns false if two args are passed
UserGroup: MadisonPHP