Skip to content
This repository was archived by the owner on Aug 24, 2021. It is now read-only.

Test readline error is handled properly #28

Closed
wants to merge 1 commit into from
Closed

Test readline error is handled properly #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ext/readline/tests/readline_error.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
--TEST--
readline - test passing too many args returns false
--SKIPIF--
<?php if (!extension_loaded("readline")) die("skip"); ?>
--FILE--
<?php
var_dump(readline("test", "test"));
?>
--EXPECTF--
Warning: readline() expects at most 1 parameter, 2 given in %s on line %d
Copy link
Contributor

@krakjoe krakjoe Oct 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be an unnecessary test of ZPP

Copy link
Author

@liam-wiltshire liam-wiltshire Oct 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you recommend best to avoid this. Obviously I could suppress the error, but that seems gross, or tell it to not output errors? Unless there is another test declaration that I don't know about (probably!)

Copy link
Contributor

@petk petk Feb 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liam-wiltshire see also this discussion https://externals.io/message/103886#103989 for more info about this. Thank you.

bool(false)