This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Provide test for bug #62477 #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krakjoe
approved these changes
Oct 25, 2017
Contributor
krakjoe
left a comment
krakjoe
left a comment
There was a problem hiding this comment.
This is likely a result of ng changes, there are probably several such open bugs that are no longer applicable ... it seems reasonable to close these, however I see a problem looming ...
Usually, when a bug is fixed, it is closed by the content of the commit message. This is not a commonly known fact, and I'm not sure if we are intending to squash commits when merging upstream anyway ...
Can I get some input from ... anyone, please ?
Contributor
|
Thank you for the pull request. Since we can't know the status of this pr anymore, I'll be merging the rest of the contributions in a single commit... More info on this soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #62477 was reported in PHP 5.6; however, as this test shows, this is not a problem in the PHP 7+ branches.
User Group: Kansas City PHP