This repository was archived by the owner on Aug 24, 2021. It is now read-only.
New Test for sunrise at North and South Pole #59
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krakjoe
approved these changes
Oct 23, 2017
Contributor
|
I'm not sure, but this test might already exist upstream via https://github.com/php/php-src/blob/master/ext/date/tests/date_sunrise_variation8.phpt. |
Author
|
It seems they have the same purpose. I'm closing this. Duplicated tests are not helpful. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests validates if the
date_sunrisefunction returnsfalseat the 26 July for both Poles.On this day the sun did not rise at both locations. At the North Pole because the sun is up the hole day and at the South Pole because it's night for 24 hours.
This Test was contributed by the PHP Usergroup Münster (phpugms)