This repository was archived by the owner on Aug 24, 2021. It is now read-only.
Added tests for xml_parser_set_option #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggering invalid encoding value error
krakjoe
suggested changes
Oct 27, 2017
Contributor
krakjoe
left a comment
krakjoe
left a comment
There was a problem hiding this comment.
I think just one call to set skip white option is enough to cover the line, it would appear the two lines create identical coverage.
Similarly, just one call to set the target encoding to something invalid will create the same coverage.
Contributor
Author
|
@krakjoe I removed the doubled up testing lines per your suggestion. |
carusogabriel
approved these changes
Feb 9, 2019
Contributor
|
Applied via php/php-src@e727fac in the php-src repository to PHP-7.4 and master branches. Thank you @mbniebergall for the pull request and @carusogabriel, @krakjoe for the review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests when setting the skip whitespace option for xml_parser_set_option and tests when setting the target encoding with an invalid value, which triggers the "Unsupported target encoding..." error.
Tests http://gcov.php.net/PHP_7_2/lcov_html/ext/xml/xml.c.gcov.php lines 1604-1606 and 1612-1613.
Credit: PHP TestFest 2017 - Utah PHP User Group (UPHPU)