Skip to content

Conversation

@dantleech
Copy link
Member

This is just an early commit to register that I'm working on it, nothing works yet, so don't pay it much attention.

- Not finished
@dantleech
Copy link
Member Author

Heh, I see that @sixty-nine has actually written a parser already, serves me right for not checking the issues first #18.

@dbu
Copy link
Member

dbu commented Jan 11, 2013

uh oh. i suggest we try to merge the two efforts. #18 seems to have stopped on an open question that we were not able to figure out back then. @sixty-nine are you ok if @dantleech would take your code over to phpcr-utils and combine with his to finalize things?

if you both want to work on the PR, i can also give you write access to phpcr-utils so you can collaborate.

@sixty-nine
Copy link
Member

yes I agree, but basically the parser is written, all that remains to do on my side (and I don't really have time to figure out how) is to actually generate the node definitions.

@sixty-nine
Copy link
Member

BTW @dantleech I remain at your disposal if you need information about what already exists.

@dbu
Copy link
Member

dbu commented Jan 11, 2013

@dantleech would you be ok to do a PR against the cnd-parser branch (you can select the target branch when creating a PR, master is just the default). you could add your tests and eventual cleanup. plus the open question mentioned in #18

@dantleech
Copy link
Member Author

yeah sure. will have a look at somepoint today.

@dbu
Copy link
Member

dbu commented Jan 11, 2013

superseeded by #31

@dbu dbu closed this Jan 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants