-
Notifications
You must be signed in to change notification settings - Fork 30
CND parser #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CND parser #31
Conversation
…t the child nodes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before merging we should remove comments like this. should we not throw an exception instead if we encounter something undefined?
|
#18 mentions: In the jackalope implementation, for the properties definitions NodeTypeDefinitionInterface::getDeclaredPropertyDefinitions() will return a mutable list so that it's possible to add properties definitions, but NodeTypeDefinitionInterface::getDeclaredChildNodeDefinitions() returns null so that it seems not possible to add child nodes definitions. @sixty-nine: is this still relevant or did you find a solution? |
|
in case it helps, there is the java code for parsing cnd http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-jcr-commons/src/main/java/org/apache/jackrabbit/commons/cnd/CompactNodeTypeDefReader.java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we care much about this issue. i sent an email to the jackrabbit list, maybe we get some feedback.
the test for now just uses the jackrabbit cnd with this line and another line with the same problem commented out.
this is the parser @sixty-nine started. it seems to be good now, parses the full jackrabbit default cnd, minus two lines with content violating the syntax.