Skip to content

Conversation

@dbu
Copy link
Member

@dbu dbu commented Jan 11, 2013

this is the parser @sixty-nine started. it seems to be good now, parses the full jackrabbit default cnd, minus two lines with content violating the syntax.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before merging we should remove comments like this. should we not throw an exception instead if we encounter something undefined?

@dbu
Copy link
Member Author

dbu commented Jan 11, 2013

#18 mentions: In the jackalope implementation, for the properties definitions NodeTypeDefinitionInterface::getDeclaredPropertyDefinitions() will return a mutable list so that it's possible to add properties definitions, but NodeTypeDefinitionInterface::getDeclaredChildNodeDefinitions() returns null so that it seems not possible to add child nodes definitions.

@sixty-nine: is this still relevant or did you find a solution?

@dbu
Copy link
Member Author

dbu commented Mar 1, 2013

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we care much about this issue. i sent an email to the jackrabbit list, maybe we get some feedback.

the test for now just uses the jackrabbit cnd with this line and another line with the same problem commented out.

dbu added a commit that referenced this pull request Mar 28, 2013
@dbu dbu merged commit eb3b2e2 into master Mar 28, 2013
@dbu dbu deleted the cnd-parser branch March 28, 2013 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants