Skip to content

Conversation

@dbu
Copy link
Member

@dbu dbu commented Jun 25, 2013

No description provided.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the list of commands was totally outdated. better point to the self-doc than trying to replicate it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a change in behaviour, but i think it makes sense. before we skipped things like the jcr:resource of an nt:file node, which is stupid and confusing. the intention was to not dump the version history and similar things by default, and to not delete that in the purge operation.

@dantleech so now this would be the place for your input as i closed #73 and merged into here to avoid the testing chaos i produced. ok if we do that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the road atm, not quite sure of implications of the sys node change, but if you and lukas agree thats ok by me. One thing i was going to suggest was maybe moving the repository exception to a method to avoide the several "if throw" methods.

Can try and have a proper look thos evening if I manage to plug my laptop in!

David Buchmann notifications@github.com a écrit :

  *
  * @param ItemInterface $item
  */
 public static function isSystemItem(ItemInterface $item)
 {
  •    if ($item->getDepth() > 1) {
    
  •        return false;
    
  •    }
    

this is a change in behaviour, but i think it makes sense. before we
skipped things like the jcr:resource of an nt:file node, which is
stupid and confusing. the intention was to not dump the version history
and similar things by default, and to not delete that in the purge
operation.

@dantleech so now this would be the place for your input as i closed
#73 and merged into here to avoid the testing chaos i produced. ok if
we do that?


Reply to this email directly or view it on GitHub:
https://github.com/phpcr/phpcr-utils/pull/72/files#r4884943

Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, will move that check to a method.

dbu added 2 commits June 28, 2013 16:36
Conflicts:
	tests/PHPCR/Tests/Util/Console/Command/BaseCommandTest.php
dbu added a commit that referenced this pull request Jun 28, 2013
cleaning up the dump command parameters
@dbu dbu merged commit 04f0b23 into master Jun 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants