improve test coverage - and of course fix a few glitches uncovered by the tests #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
There was a problem hiding this comment.
this is a change in behaviour, but i think it makes sense. before we skipped things like the jcr:resource of an nt:file node, which is stupid and confusing. the intention was to not dump the version history and similar things by default, and to not delete that in the purge operation.
Member
Author
There was a problem hiding this comment.
@dantleech you worked on those commands quite a bit. do you agree with
this change as well?
Member
Author
|
seems this one is linked to #72 as well. i will just merge the two PR, seems i did something stupid splitting them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.