Skip to content

QA tests

Choose a tag to compare

View all tags
@g105b g105b released this 14 Mar 13:56
v3.5.1
f724ad7
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.

Tighter quality assurance tests have finally been implemented into DomTemplate.

This issue has been tracked for a while, but because of the extra complexity DomTemplate adds over Dom, it was proving difficult to get any traction with Code Sniffer and Mess Detector tests.

This latest release has not changed any external facing functionality, but internally has implemented.

The drive to implement phpcs and phpmd forced a refactor of some internal classes. Several large, procedural methods have been broken down intro smaller private helpers across the binding pipeline, especially BindableCache, TableBinder, HTMLAttributeBinder, ListBinder, PartialExpander and CommentIni.

The public behaviour looks intended to stay broadly the same, but the internal flow is now much more decomposed: bindable-class discovery, table normalisation/binding, attribute binding, list-item binding, and comment-INI parsing have all been split into narrower responsibilities.

Cyclomatic complexity is now below the measured threshold of 10 and all systems are green. Enjoy, and have fun!

Assets 2
Loading